anders/Wallet
1
0
Fork 0
Code Issues Projects Releases Packages Wiki Activity

better handing of errors + prevent joining the same wallet more that once

Browse source
This commit is contained in:
Matias Alejo Garcia 2015-08-12 11:08:33 -03:00
commit 033f7c163f
7 changed files with 167 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/js/services/addressService.js
View file

@ -1,7 +1,7 @@
'use strict';
'use strict';
angular.module('copayApp.services')
.factory('addressService', function(storageService, profileService, $log, $timeout, lodash) {
.factory('addressService', function(storageService, profileService, $log, $timeout, lodash, bwsError, gettext) {
var root = {};
@ -34,8 +34,7 @@ angular.module('copayApp.services')
root._createAddress(walletId, cb);
}, 5000);
}
$log.debug('Creating address ERROR:', err);
return cb(err);
return bwsError.cb(err, gettext('Could not create address'), cb);
}
return cb(null, addr.address);
});

125
src/js/services/bwsError.js Normal file
View file

@ -0,0 +1,125 @@
'use strict';
angular.module('copayApp.services')
.factory('bwsError', function bwcErrorService($log, gettext) {
var root = {};
root.msg = function(err, prefix) {
var body = '';
prefix = prefix || '';
if (err && err.code) {
switch(err.code) {
case 'CONNECTION_ERROR':
body = gettext('Network connection error');
break;
;;
case 'NOT_FOUND':
body = gettext('Wallet service not found');
break;
;;
case 'BAD_SIGNATURES':
body = gettext('Signatures rejected by server');
break;
;;
case 'COPAYER_DATA_MISMATCH':
body = gettext('Copayer data mismatch');
break;
;;
case 'COPAYER_IN_WALLET':
body = gettext('Copayer already in this wallet');
break;
;;
case 'COPAYER_REGISTERED':
body = gettext('Copayer already registered');
break;
;;
case 'COPAYER_VOTED':
body = gettext('Copayer already voted on this spend proposal');
break;
;;
case 'DUST_AMOUNT':
body = gettext('Amount below dust threshold');
break;
;;
case 'INCORRECT_ADDRESS_NETWORK':
body = gettext('Incorrect address network');
break;
;;
case 'INSUFFICIENT_FUNDS':
body = gettext('Insufficient funds');
break;
;;
case 'INSUFFICIENT_FUNDS_FOR_FEE':
body = gettext('Insufficient funds for fee');
break;
;;
case 'INVALID_ADDRESS':
body = gettext('Invalid address');
break;
;;
case 'LOCKED_FUNDS':
body = gettext('Funds are locked by pending spend proposals');
break;
;;
case 'NOT_AUTHORIZED':
body = gettext('Not authorized');
break;
;;
case 'TX_ALREADY_BROADCASTED':
body = gettext('Transaction already broadcasted');
break;
;;
case 'TX_CANNOT_CREATE':
body = gettext('Locktime in effect. Please wait to create a new spend proposal');
break;
;;
case 'TX_CANNOT_REMOVE':
body = gettext('Locktime in effect. Please wait to remove this spend proposal');
break;
;;
case 'TX_NOT_ACCEPTED':
body = gettext('Spend proposal is not accepted');
break;
;;
case 'TX_NOT_FOUND':
body = gettext('Spend proposal not found');
break;
;;
case 'TX_NOT_PENDING':
body = gettext('The spend proposal is not pending');
break;
;;
case 'UPGRADE_NEEDED':
body = gettext('Please upgrade Copay to perform this action');
break;
;;
case 'WALLET_ALREADY_EXISTS':
body = gettext('Wallet already exists');
break;
;;
case 'WALLET_FULL':
body = gettext('Wallet is full');
break;
;;
case 'WALLET_NOT_COMPLETE':
body = gettext('Wallet is not complete');
break;
;;
case 'WALLET_NOT_FOUND':
body = gettext('Wallet not found');
break;
;;
}
}
var msg = prefix + ( body ? ': ' + body : '');
$log.warn("BWC ERROR:" + msg);
return msg;
};
root.cb = function (err,prefix, cb) {
return cb(root.msg(err, prefix))
};
return root;
});

35
src/js/services/profileService.js
View file

@ -1,6 +1,6 @@
'use strict';
angular.module('copayApp.services')
.factory('profileService', function profileServiceFactory($rootScope, $location, $timeout, $filter, $log, lodash, storageService, bwcService, configService, notificationService, isChromeApp, isCordova, gettext, nodeWebkit) {
.factory('profileService', function profileServiceFactory($rootScope, $location, $timeout, $filter, $log, lodash, storageService, bwcService, configService, notificationService, isChromeApp, isCordova, gettext, nodeWebkit, bwsError) {
var root = {};
@ -11,22 +11,6 @@ angular.module('copayApp.services')
root.getUtils = function() {
return bwcService.getUtils();
};
root.errorCb = function(err, prefix, cb) {
var body = '';
prefix = gettext(prefix);
if (!err || !err.code) return cb(prefix);
switch(err.code) {
case 'CONNECTION_ERROR':
body = gettext('Network connection error');
;;
}
return cb(prefix + ( body ? ': ' + body : ''));
};
root.formatAmount = function(amount) {
var config = configService.getSync().wallet.settings;
if (config.unitCode == 'sat') return amount;
@ -191,7 +175,7 @@ angular.module('copayApp.services')
walletClient.createWallet('Personal Wallet', 'me', 1, 1, {
network: 'livenet'
}, function(err) {
if (err) return root.errorCb(err, 'Error creating wallet', cb);
if (err) return bwsError.cb(err, gettext('Error creating wallet'), cb);
var p = Profile.create({
credentials: [JSON.parse(walletClient.export())],
});
@ -213,7 +197,7 @@ angular.module('copayApp.services')
walletClient.createWallet(opts.name, opts.myName || 'me', opts.m, opts.n, {
network: opts.networkName
}, function(err, secret) {
if (err) return root.errorCb(err, 'Error creating wallet', cb);
if (err) return bwsError.cb(err, gettext('Error creating wallet'), cb);
root.profile.credentials.push(JSON.parse(walletClient.export()));
root.setWalletClients();
@ -236,8 +220,19 @@ angular.module('copayApp.services')
return cb(gettext('Could not join using the specified extended private key'));
}
}
try {
var walletData = this.getUtils().fromSecret(opts.secret);
if (root.walletClients[walletData.walletId])
return cb(gettext('Cannot join the same wallet more that once'));
} catch (ex) {
return cb(gettext('Bad wallet invitation'));
}
walletClient.joinWallet(opts.secret, opts.myName || 'me', function(err) {
if (err) return cb(err);
if (err) return bwsError.cb(err, gettext('Could not join wallet'), cb);
root.profile.credentials.push(JSON.parse(walletClient.export()));
root.setWalletClients();