Merge pull request #2644 from matiu/bug/android-file

write file not as blobs

src/js/controllers/index.js

@@ -246,13 +246,13 @@ angular.module('copayApp.controllers').controller('indexController', function($r
   };
 
   self.handleError = function(err) {
-    $log.debug('ERROR:', err);
+    $log.warn('Client ERROR:', err);
     if (err.code === 'NOTAUTHORIZED') {
       $scope.$emit('Local/NotAuthorized');
     } else if (err.code === 'NOTFOUND') {
       $scope.$emit('Local/BWSNotFound');
     } else {
-      $scope.$emit('Local/ClientError', err);
+      $scope.$emit('Local/ClientError', (err.error ? err.error : err));
     }
   };
   self.openWallet = function() {
@@ -448,7 +448,7 @@ angular.module('copayApp.controllers').controller('indexController', function($r
       self.setOngoingProcess('recreating', false);
 
       if (err) {
-        self.clientError('Could not recreate wallet:' + err);
+        self.handleError(err);
         $rootScope.$apply();
         return;
       }
@@ -485,7 +485,7 @@ angular.module('copayApp.controllers').controller('indexController', function($r
       if (err) {
         if (self.walletId == walletId)
           self.setOngoingProcess('scanning', false);
-        self.clientError('Could not scan wallet:' + err);
+        self.handleError(err);
         $rootScope.$apply();
       }
     });
@@ -533,6 +533,9 @@ angular.module('copayApp.controllers').controller('indexController', function($r
   // UX event handlers
   $rootScope.$on('Local/ColorUpdated', function(event) {
     self.updateColor();
+    $timeout(function() {
+      $rootScope.$apply();
+    });
   });
 
   $rootScope.$on('Local/UnitSettingUpdated', function(event) {
@@ -569,7 +572,9 @@ angular.module('copayApp.controllers').controller('indexController', function($r
 
   $rootScope.$on('Local/BackupDone', function(event) {
     self.needsBackup = false;
-    storageService.setBackupFlag(self.walletId, function() {});
+    storageService.setBackupFlag(self.walletId, function(err) {
+      if (err) $rootScope.$emit('Local/DeviceError', err)
+    });
   });
 
   $rootScope.$on('Local/NotAuthorized', function(event) {

src/js/services/fileStorage.js

@@ -3,16 +3,20 @@
 angular.module('copayApp.services')
   .factory('fileStorageService', function(lodash, $log) {
     var root = {},
-      fs;
+      _fs, _dir;
-
 
     root.init = function(cb) {
-      if (fs) return cb(null, fs);
+      if (_dir) return cb(null, _fs, _dir);
 
       function onFileSystemSuccess(fileSystem) {
         console.log('File system started: ', fileSystem.name, fileSystem.root.name);
-        fs = fileSystem;
+        _fs = fileSystem;
-        return cb(null, fs);
+        root.getDir(function(err, newDir) {
+          if (err || !newDir.nativeURL) return cb(err);
+          _dir = newDir
+          $log.debug("Got main dir:", _dir.nativeURL);
+          return cb(null, _fs, _dir);
+        });
       }
 
       function fail(evt) {
@@ -24,13 +28,9 @@ angular.module('copayApp.services')
       window.requestFileSystem(LocalFileSystem.PERSISTENT, 0, onFileSystemSuccess, fail);
     };
 
-
     root.get = function(k, cb) {
-      root.init(function(err, fs) {
+      root.init(function(err, fs, dir) {
         if (err) return cb(err);
-        root.getDir(function(err, dir) {
-          if (err) return cb(err);
-          $log.debug(".get: Got main dir:", dir.nativeURL);
         dir.getFile(k, {
           create: false,
         }, function(fileEntry) {
@@ -51,16 +51,12 @@ angular.module('copayApp.services')
           if (err.code == 1) return cb();
           else return cb(err);
         });
-        });
       })
     };
 
     root.set = function(k, v, cb) {
-      root.init(function(err, fs) {
+      root.init(function(err, fs, dir) {
         if (err) return cb(err);
-        root.getDir(function(err, dir) {
-          if (err) return cb(err);
-          $log.debug(".set: Got main dir:", dir.nativeURL);
         dir.getFile(k, {
           create: true,
         }, function(fileEntry) {
@@ -73,23 +69,24 @@ angular.module('copayApp.services')
             };
 
             fileWriter.onerror = function(e) {
-                console.log('Write failed: ' + e.toString());
+              var err = e.error ? e.error : JSON.stringify(e);
-                return cb('Fail to write:', e.toString());
+              console.log('Write failed: ' + err);
+              return cb('Fail to write:' + err);
             };
 
             if (lodash.isObject(v))
               v = JSON.stringify(v);
 
+            if (!lodash.isString(v)){
+              v = v.toString();
+            }
+
             $log.debug('Writing:', k, v);
-              var blob = new Blob([v], {
+            fileWriter.write(v);
-                type: "text/plain"
-              });
-              fileWriter.write(blob);
 
           }, cb);
         });
       });
-      });
     };
 
 
@@ -105,13 +102,14 @@ angular.module('copayApp.services')
       //   url = 'ms-appdata:///local/';
       window.resolveLocalFileSystemURL(url, function(dir) {
         return cb(null, dir);
+      }, function(err) {
+        $log.warn(err);
+        return cb(err || 'Could not resolve filesystem:' + url);
       });
     };
 
     root.remove = function(k, cb) {
-      root.init(function(err, fs) {
+      root.init(function(err, fs, dir) {
-        if (err) return cb(err);
-        root.getDir(function(err, dir) {
         if (err) return cb(err);
         dir.getFile(k, {
           create: false,
@@ -123,7 +121,6 @@ angular.module('copayApp.services')
           }, cb, cb);
         });
       });
-      });
     };
 
     /**
@@ -140,6 +137,5 @@ angular.module('copayApp.services')
         });
     };
 
-
     return root;
   });