Added tests for single slash. Removed some unused code.

This commit is contained in:
Brendon Duncan 2018-08-29 10:04:02 +12:00
commit 217b02504a
2 changed files with 22 additions and 13 deletions

View file

@ -12,24 +12,12 @@
function bitcoinUriService(bitcoinCashJsService, bwcService, $log) { function bitcoinUriService(bitcoinCashJsService, bwcService, $log) {
var bch = bitcoinCashJsService.getBitcoinCashJs(); var bch = bitcoinCashJsService.getBitcoinCashJs();
var bitcore = bwcService.getBitcore(); var bitcore = bwcService.getBitcore();
var cashAddrRe = /^((?:q|p)[a-z0-9]{41})|((?:Q|P)[A-Z0-9]{41})$/;
var service = { var service = {
parse: parse parse: parse
}; };
return service; return service;
function generateTestData() {
var privateKey = new bch.PrivateKey('testnet');
var address1 = privateKey.toAddress();
console.log('legacy pub:', address1.toString());
//var addrss = bitcoinCashJsService.readAddress(address1);
//console.log('generated:', addrss.cashaddr);
//bch.Address.fromString(address1, 'testnet');
console.log('generated:', address1.toString('cashaddr'));
}
function bitpayAddrOnMainnet(address) { function bitpayAddrOnMainnet(address) {
var Address = bch.Address; var Address = bch.Address;
@ -52,7 +40,6 @@
return result; return result;
} }
function cashAddrOnMainnet(address) { function cashAddrOnMainnet(address) {
var Address = bch.Address; var Address = bch.Address;
var CashAddrFormat = Address.CashAddrFormat; var CashAddrFormat = Address.CashAddrFormat;

View file

@ -138,6 +138,17 @@ fdescribe('bitcoinUriService', function() {
expect(parsed.testnet).toBe(false); expect(parsed.testnet).toBe(false);
}); });
it('Bitcoin uri with slash', function() {
var parsed = bitcoinUriService.parse('bitcoin:/1GhpYmbRaf73AZRxDwAGr6653iZBGzdgeA');
expect(parsed.isValid).toBe(true);
expect(parsed.coin).toBe('btc');
expect(parsed.publicAddress.asReceived).toBe('1GhpYmbRaf73AZRxDwAGr6653iZBGzdgeA');
expect(parsed.publicAddress.legacy).toBe('1GhpYmbRaf73AZRxDwAGr6653iZBGzdgeA');
expect(parsed.testnet).toBe(false);
});
it('Bitcoin uri with slashes', function() { it('Bitcoin uri with slashes', function() {
var parsed = bitcoinUriService.parse('bitcoin://18PCPhgZJjLxe9g3Q1BXLpL5aVut1fW3aX'); var parsed = bitcoinUriService.parse('bitcoin://18PCPhgZJjLxe9g3Q1BXLpL5aVut1fW3aX');
@ -215,6 +226,17 @@ fdescribe('bitcoinUriService', function() {
expect(parsed.testnet).toBe(false); expect(parsed.testnet).toBe(false);
}); });
it('cashAddr with slash', function() {
var parsed = bitcoinUriService.parse('bitcoincash:/qzdectfmuw0xxztfx7mh045830dqcshj85hr44l35a');
expect(parsed.isValid).toBe(true);
expect(parsed.coin).toBe('bch');
expect(parsed.publicAddress.asReceived).toBe('qzdectfmuw0xxztfx7mh045830dqcshj85hr44l35a');
expect(parsed.publicAddress.legacy).toBe('1FBnq5gZhzTvvcJBjA7C2P3bKQZCiJaG1x');
expect(parsed.testnet).toBe(false);
});
it('cashAddr with slashes', function() { it('cashAddr with slashes', function() {
var parsed = bitcoinUriService.parse('bitcoincash://qpj966w8utue75lqqq3rlgh20zkz3rmydqpq8syv9c'); var parsed = bitcoinUriService.parse('bitcoincash://qpj966w8utue75lqqq3rlgh20zkz3rmydqpq8syv9c');