From 2bdf4021d22666b2d2cca66cffb1e0b9e1154547 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gabriel=20Baz=C3=A1n?= <gabrielbazan7@hotmail.com>
Date: Fri, 2 Sep 2016 14:50:50 -0300
Subject: [PATCH] fix transations details note and external link

---
 public/views/includes/note.html        |  6 +++---
 public/views/modals/tx-details.html    |  2 +-
 src/js/controllers/modals/txDetails.js | 13 +++++++++++--
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/public/views/includes/note.html b/public/views/includes/note.html
index 451ac6baf..e52beba85 100644
--- a/public/views/includes/note.html
+++ b/public/views/includes/note.html
@@ -1,11 +1,11 @@
 <div class="padding">
-  <input type="text" ng-model="comment" autofocus>
+  <input type="text" ng-model="data.comment" autofocus>
 </div>
 <div class="row">
   <div class="col">
-    <button class="button button-dark button-block" ng-click="commentPopupClose(comment)" translate>Cancel</button>
+    <button class="button button-dark button-block" ng-click="commentPopupClose()" translate>Cancel</button>
   </div>
   <div class="col">
-    <button class="button button-dark button-block" ng-click="commentPopupSave(comment)" translate>Save</button>
+    <button class="button button-dark button-block" ng-click="commentPopupSave()" translate>Save</button>
   </div>
 </div>
diff --git a/public/views/modals/tx-details.html b/public/views/modals/tx-details.html
index 070f1dcda..48a92f8c6 100644
--- a/public/views/modals/tx-details.html
+++ b/public/views/modals/tx-details.html
@@ -149,7 +149,7 @@
 
       <div ng-show="btx.txid" class="tx-details-blockchain">
         <div class="text-center m20t">
-          <button class="button button-positive" ng-click="$root.openExternalLink('https://' +
+          <button class="button button-positive" ng-click="openExternalLink('https://' +
             (getShortNetworkName() == 'test' ? 'test-' : '') + 'insight.bitpay.com/tx/' + btx.txid)">
             <span class="text-gray" translate>See it on the blockchain</span>
           </button>
diff --git a/src/js/controllers/modals/txDetails.js b/src/js/controllers/modals/txDetails.js
index 84ca22954..2db8bb8b1 100644
--- a/src/js/controllers/modals/txDetails.js
+++ b/src/js/controllers/modals/txDetails.js
@@ -1,6 +1,6 @@
 'use strict';
 
-angular.module('copayApp.controllers').controller('txDetailsController', function($rootScope, $log, $scope, $filter, $stateParams, $ionicPopup, gettextCatalog, profileService, configService, lodash, txFormatService) {
+angular.module('copayApp.controllers').controller('txDetailsController', function($rootScope, $log, $scope, $filter, $stateParams, $ionicPopup, gettextCatalog, profileService, configService, lodash, txFormatService, platformInfo) {
 
   var self = $scope.self;
   var wallet = profileService.getWallet($stateParams.walletId);
@@ -36,7 +36,7 @@ angular.module('copayApp.controllers').controller('txDetailsController', functio
         txid: $scope.btx.txid,
       };
 
-      if (!lodash.isEmpty($scope.data.comment)) {
+      if ($scope.data.comment) {
         args.body = $scope.data.comment;
       };
 
@@ -80,6 +80,15 @@ angular.module('copayApp.controllers').controller('txDetailsController', functio
     });
   };
 
+  $scope.openExternalLink = function(url, target) {
+    if (platformInfo.isNW) {
+      nodeWebkit.openExternalLink(url);
+    } else {
+      target = target || '_blank';
+      var ref = window.open(url, target, 'location=no');
+    }
+  };
+
   $scope.getShortNetworkName = function() {
     var n = wallet.credentials.network;
     return n.substring(0, 4);