anders/Wallet
1
0
Fork 0
Code Issues Projects Releases Packages Wiki Activity

paypro: compensate for improperly implemented payment protocol servers.

Browse source
This commit is contained in:
Christopher Jeffrey 2014-09-23 09:22:07 -07:00
commit 4ee99603f3
1 changed files with 23 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

40
js/models/core/Wallet.js
View file

@ -1621,28 +1621,34 @@ Wallet.prototype.receivePaymentRequestACK = function(ntxid, tx, txp, ack, cb) {
memo: memo memo: memo
}; };
var tx = payment.message.transactions[0]; if (payment.message.transactions && payment.message.transactions.length) {
tx = payment.message.transactions[0];
if (!tx) { if (!tx) {
log.debug('Sending to server was not met with a returned tx.'); log.debug('Sending to server was not met with a returned tx.');
return this._checkSentTx(ntxid, function(txid) { return this._checkSentTx(ntxid, function(txid) {
log.debug('[Wallet.js.1613:txid:%s]', txid); log.debug('[Wallet.js.1613:txid:%s]', txid);
if (txid) self.store(); if (txid) self.store();
return cb(txid, txp.merchant); return cb(txid, txp.merchant);
}); });
} }
if (tx.buffer) {
if (tx.buffer) { tx.buffer = new Buffer(new Uint8Array(tx.buffer));
tx.buffer = new Buffer(new Uint8Array(tx.buffer)); tx.buffer = tx.buffer.slice(tx.offset, tx.limit);
tx.buffer = tx.buffer.slice(tx.offset, tx.limit); var ptx = new bitcore.Transaction();
var ptx = new bitcore.Transaction(); ptx.parse(tx.buffer);
ptx.parse(tx.buffer); tx = ptx;
tx = ptx; }
} else {
log.debug('WARNING: This server does not comply by standards.');
log.debug('It is not returning a copy of the transaction.');
} }
var txid = tx.getHash().toString('hex'); var txid = tx.getHash().toString('hex');
var txHex = tx.serialize().toString('hex'); var txHex = tx.serialize().toString('hex');
log.debug('Raw transaction: ', txHex); log.debug('Raw transaction: ', txHex);
// XXX This fixes the invalid signature error:
// we might as well broadcast it ourselves anyway.
this.blockchain.broadcast(txHex, function(err, txid) { this.blockchain.broadcast(txHex, function(err, txid) {
log.debug('BITCOIND txid:', txid); log.debug('BITCOIND txid:', txid);
if (txid) { if (txid) {