From 6246e6296201b659b9c0c18a55a706de65cca52b Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Fri, 15 Aug 2014 17:26:40 -0400 Subject: [PATCH 1/2] paypro: use BIP21 object in latest bitcore. fixes #1104. see #1083. --- js/controllers/send.js | 6 +++--- js/models/core/Wallet.js | 5 ++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/js/controllers/send.js b/js/controllers/send.js index f242dd82d..2a72164d3 100644 --- a/js/controllers/send.js +++ b/js/controllers/send.js @@ -112,7 +112,7 @@ angular.module('copayApp.controllers').controller('SendController', var uri; if (address.indexOf('bitcoin:') === 0) { - uri = copay.HDPath.parseBitcoinURI(address); + uri = new bitcore.BIP21(address).data; } else if (address.indexOf('Merchant: ') === 0) { uri = { merchant: address.split(/\s+/)[1] @@ -411,7 +411,7 @@ angular.module('copayApp.controllers').controller('SendController', merchant: value }; } else { - uri = copay.HDPath.parseBitcoinURI(value); + uri = new bitcore.BIP21(value).data; } if (!uri || !uri.merchant) { return; @@ -476,7 +476,7 @@ angular.module('copayApp.controllers').controller('SendController', // delete the `merchant` property from the scope. var unregister = scope.$watch('address', function() { var val = scope.sendForm.address.$viewValue || ''; - var uri = copay.HDPath.parseBitcoinURI(val); + var uri = new bitcore.BIP21(val).data; if (!uri || !uri.merchant) { delete $rootScope.merchant; scope.sendForm.amount.$setViewValue(''); diff --git a/js/models/core/Wallet.js b/js/models/core/Wallet.js index 3e68f56d1..51183fec7 100644 --- a/js/models/core/Wallet.js +++ b/js/models/core/Wallet.js @@ -4,7 +4,6 @@ var http = require('http'); var EventEmitter = require('events').EventEmitter; var async = require('async'); var preconditions = require('preconditions').singleton(); -var parseBitcoinURI = require('./HDPath').parseBitcoinURI; var util = require('util'); var bitcore = require('bitcore'); @@ -46,7 +45,7 @@ function Wallet(opts) { this.log('creating ' + opts.requiredCopayers + ' of ' + opts.totalCopayers + ' wallet'); this.id = opts.id || Wallet.getRandomId(); - this.lock = new WalletLock(this.storage, this.id, opts.lockTimeOutMin); + this.lock = new WalletLock(this.storage, this.id, opts.lockTimeOutMin); this.name = opts.name; @@ -777,7 +776,7 @@ Wallet.prototype.createPaymentTx = function(options, cb) { options.uri = options.uri || options.url; if (options.uri.indexOf('bitcoin:') === 0) { - options.uri = parseBitcoinURI(options.uri).merchant; + options.uri = new bitcore.BIP21(options.uri).data.merchant; if (!options.uri) { return cb(new Error('No URI.')); } From d7ab195b7ae26cfb40efa41cbf0d84c85505ba69 Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Mon, 18 Aug 2014 11:34:49 -0700 Subject: [PATCH 2/2] wallet: remove useless node module require. --- js/models/core/Wallet.js | 1 - 1 file changed, 1 deletion(-) diff --git a/js/models/core/Wallet.js b/js/models/core/Wallet.js index 51183fec7..303c06d67 100644 --- a/js/models/core/Wallet.js +++ b/js/models/core/Wallet.js @@ -1,6 +1,5 @@ 'use strict'; -var http = require('http'); var EventEmitter = require('events').EventEmitter; var async = require('async'); var preconditions = require('preconditions').singleton();