anders/Wallet
1
0
Fork 0
Code Issues Projects Releases Packages Wiki Activity

Clean code 3

Browse source
This commit is contained in:
Gustavo Maximiliano Cortez 2017-01-13 01:21:32 -03:00
commit 5666a66e1d
No known key found for this signature in database
GPG key ID: 15EDAD8D9F2EB1AF
2 changed files with 12 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/js/controllers/amount.js
View file

@ -1,6 +1,6 @@
'use strict'; 'use strict';
angular.module('copayApp.controllers').controller('amountController', function($scope, $filter, $timeout, $ionicScrollDelegate, $ionicHistory, gettextCatalog, platformInfo, lodash, configService, rateService, $stateParams, $window, $state, $log, txFormatService, ongoingProcess, bitpayCardService, popupService, bwcError, payproService, profileService, bitcore, amazonService, glideraService, appConfigService) { angular.module('copayApp.controllers').controller('amountController', function($scope, $filter, $timeout, $ionicScrollDelegate, $ionicHistory, gettextCatalog, platformInfo, lodash, configService, rateService, $stateParams, $window, $state, $log, txFormatService, ongoingProcess, bitpayCardService, popupService, bwcError, payproService, profileService, bitcore, amazonService, glideraService) {
var unitToSatoshi; var unitToSatoshi;
var satToUnit; var satToUnit;
var unitDecimals; var unitDecimals;

33
src/js/controllers/confirm.js
View file

@ -1,6 +1,6 @@
'use strict'; 'use strict';
angular.module('copayApp.controllers').controller('confirmController', function($rootScope, $scope, $interval, $filter, $timeout, $ionicScrollDelegate, gettextCatalog, walletService, platformInfo, lodash, configService, rateService, $stateParams, $window, $state, $log, profileService, bitcore, txFormatService, ongoingProcess, $ionicModal, popupService, $ionicHistory, $ionicConfig, payproService, feeService, amazonService, glideraService, bwcError, bitpayCardService, appConfigService) { angular.module('copayApp.controllers').controller('confirmController', function($rootScope, $scope, $interval, $filter, $timeout, $ionicScrollDelegate, gettextCatalog, walletService, platformInfo, lodash, configService, rateService, $stateParams, $window, $state, $log, profileService, bitcore, txFormatService, ongoingProcess, $ionicModal, popupService, $ionicHistory, $ionicConfig, payproService, feeService, amazonService, glideraService, bwcError, bitpayCardService) {
var cachedTxp = {}; var cachedTxp = {};
var toAmount; var toAmount;
var isChromeApp = platformInfo.isChromeApp; var isChromeApp = platformInfo.isChromeApp;
@ -527,8 +527,8 @@ angular.module('copayApp.controllers').controller('confirmController', function(
} }
}); });
return; return;
} }
ongoingProcess.set('creatingTx', true, onSendStatusChange); ongoingProcess.set('creatingTx', true, onSendStatusChange);
createTx(wallet, false, function(err, txp) { createTx(wallet, false, function(err, txp) {
ongoingProcess.set('creatingTx', false, onSendStatusChange); ongoingProcess.set('creatingTx', false, onSendStatusChange);
@ -579,14 +579,12 @@ angular.module('copayApp.controllers').controller('confirmController', function(
( (
processName === 'broadcastingTx' || processName === 'broadcastingTx' ||
((processName === 'signingTx') && $scope.wallet.m > 1) || ((processName === 'signingTx') && $scope.wallet.m > 1) ||
(processName == 'sendingTx' && !$scope.wallet.canSign() && !$scope.wallet.isPrivKeyExternal()) || (processName == 'sendingTx' && !$scope.wallet.canSign() && !$scope.wallet.isPrivKeyExternal())
(processName == 'buyingBitcoin') ||
(processName == 'sellingBitcoin')
) && !isOn) { ) && !isOn) {
$scope.sendStatus = 'success'; $scope.sendStatus = 'success';
$timeout(function() { $timeout(function() {
$scope.$digest(); $scope.$digest();
}, 100) }, 100);
} else if (showName) { } else if (showName) {
$scope.sendStatus = showName; $scope.sendStatus = showName;
} }
@ -804,26 +802,18 @@ angular.module('copayApp.controllers').controller('confirmController', function(
}); });
}; };
function publishAndSign(wallet, txp, onSendStatusChange, cb) { function publishAndSign(wallet, txp, onSendStatusChange) {
if (!wallet.canSign() && !wallet.isPrivKeyExternal()) { if (!wallet.canSign() && !wallet.isPrivKeyExternal()) {
$log.info('No signing proposal: No private key'); $log.info('No signing proposal: No private key');
walletService.onlyPublish(wallet, txp, function(err) { return walletService.onlyPublish(wallet, txp, function(err) {
if (err) { if (err) setSendError(err);
if (cb) return cb(err);
else return setSendError(err);
}
if (cb) return cb();
else return;
}, onSendStatusChange); }, onSendStatusChange);
} }
walletService.publishAndSign(wallet, txp, function(err, txp) { walletService.publishAndSign(wallet, txp, function(err, txp) {
if (err) { if (err) return setSendError(err);
if (cb) return cb(err);
else return setSendError(err);
}
var previousView = $ionicHistory.viewHistory().backView && $ionicHistory.viewHistory().backView.stateName; var previousView = $ionicHistory.viewHistory().backView && $ionicHistory.viewHistory().backView.stateName;
var fromAmazon = previousView.match(/tabs.giftcards.amazon/) ? true : false; var fromAmazon = previousView.match(/tabs.giftcards.amazon/) ? true : false;
@ -842,7 +832,6 @@ angular.module('copayApp.controllers').controller('confirmController', function(
ongoingProcess.set('creatingGiftCard', true); ongoingProcess.set('creatingGiftCard', true);
debounceCreate(count, dataSrc, onSendStatusChange); debounceCreate(count, dataSrc, onSendStatusChange);
} }
if (cb) return cb();
}, onSendStatusChange); }, onSendStatusChange);
}; };
@ -905,9 +894,9 @@ angular.module('copayApp.controllers').controller('confirmController', function(
} }
if (lodash.isEmpty(res)) return; if (lodash.isEmpty(res)) return;
if (unitName == 'bits') { if (unitName == 'bits') {
$scope.exchangeRate = '1,000,000 bits ~ ' + res.data.rate + ' ' + alternativeIsoCode; $scope.exchangeRate = '1,000,000 bits ~ ' + res.rate + ' ' + alternativeIsoCode;
} else { } else {
$scope.exchangeRate = '1 BTC ~ ' + res.data.rate + ' ' + alternativeIsoCode; $scope.exchangeRate = '1 BTC ~ ' + res.rate + ' ' + alternativeIsoCode;
} }
}); });
}; };