From 8a1a3adf9055c2bee871563c489750a70e17d8a2 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 10:30:53 -0400 Subject: [PATCH 01/10] fix karma tests after rebase --- util/build.js | 41 +++++++++++++---------------------------- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/util/build.js b/util/build.js index d8a41e3cf..71c96b6c8 100644 --- a/util/build.js +++ b/util/build.js @@ -13,7 +13,7 @@ var puts = function(error, stdout, stderr) { //sys.puts(stderr); }; -var pack = function (params) { +var pack = function(params) { var file = require.resolve('soop'); var dir = file.substr(0, file.length - String('soop.js').length); var preludePath = dir + 'example/custom_prelude.js'; @@ -48,9 +48,6 @@ var createBundle = function(opts) { b.require('./copay', { expose: 'copay' }); - b.require('./copay', { - expose: '../copay' - }); b.require('./version'); // b.external('bitcore'); b.require('./js/models/core/WalletFactory', { @@ -60,27 +57,24 @@ var createBundle = function(opts) { b.require('./js/models/core/Wallet', { expose: '../js/models/core/Wallet' }); + b.require('./js/models/core/Wallet', { + expose: '../js/models/core/Wallet' + }); b.require('./js/models/core/Wallet', { expose: '../../js/models/core/Wallet' }); b.require('./test/mocks/FakeStorage', { expose: './mocks/FakeStorage' }); - b.require('./test/mocks/FakePayProServer', { - expose: './mocks/FakePayProServer' - }); - b.require('./test/mocks/FakePayProServer', { - expose: '../../mocks/FakePayProServer' - }); b.require('./test/mocks/FakeBlockchain', { expose: './mocks/FakeBlockchain' }); - b.require('./test/mocks/FakeLocalStorage', { - expose: './mocks/FakeLocalStorage' - }); b.require('./test/mocks/FakeNetwork', { expose: './mocks/FakeNetwork' }); + b.require('./test/mocks/FakePayProServer', { + expose: '../../mocks/FakePayProServer' + }); b.require('./js/models/network/WebRTC', { expose: '../js/models/network/WebRTC' }); @@ -96,24 +90,15 @@ var createBundle = function(opts) { b.require('./js/models/core/Passphrase', { expose: '../js/models/core/Passphrase' }); - b.require('./js/models/core/Message', { - expose: '../js/models/core/Message' - }); - b.require('./config', { - expose: '../config' - }); - b.require('./js/models/core/HDPath', { - expose: '../js/models/core/HDPath' - }); - if (opts.debug) { + if (opts.dontminify) { //include dev dependencies b.require('sinon'); b.require('blanket'); b.require('soop'); } - if (!opts.debug) { + if (!opts.dontminify) { b.transform({ global: true }, 'uglifyify'); @@ -128,10 +113,10 @@ if (require.main === module) { }; var program = require('commander'); program - .version('0.0.1') - .option('-d, --debug', 'Development. Don\'t minify the codem and include debug packages.') - .option('-o, --stdout', 'Specify output as stdout') - .parse(process.argv); + .version('0.0.1') + .option('-d, --dontminify', 'Development. Don\'t minify the code.') + .option('-o, --stdout', 'Specify output as stdout') + .parse(process.argv); createVersion(); var copayBundle = createBundle(program); From fe0bdb3eb3ac262cd814b7a98357b2e2a9fd144d Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 10:42:25 -0400 Subject: [PATCH 02/10] fixing build for index.html tests --- util/build.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/build.js b/util/build.js index 71c96b6c8..76d48fb04 100644 --- a/util/build.js +++ b/util/build.js @@ -57,15 +57,15 @@ var createBundle = function(opts) { b.require('./js/models/core/Wallet', { expose: '../js/models/core/Wallet' }); - b.require('./js/models/core/Wallet', { - expose: '../js/models/core/Wallet' - }); b.require('./js/models/core/Wallet', { expose: '../../js/models/core/Wallet' }); b.require('./test/mocks/FakeStorage', { expose: './mocks/FakeStorage' }); + b.require('./js/models/core/Message', { + expose: '../js/models/core/Message' + }); b.require('./test/mocks/FakeBlockchain', { expose: './mocks/FakeBlockchain' }); @@ -90,6 +90,9 @@ var createBundle = function(opts) { b.require('./js/models/core/Passphrase', { expose: '../js/models/core/Passphrase' }); + b.require('./config', { + expose: '../config' + }); if (opts.dontminify) { //include dev dependencies From 055b9da2f558ef76aeb13b728797d1bffb39c2ab Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 10:44:14 -0400 Subject: [PATCH 03/10] fixing build.js one error at a time --- util/build.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/build.js b/util/build.js index 76d48fb04..c2de4694d 100644 --- a/util/build.js +++ b/util/build.js @@ -63,6 +63,9 @@ var createBundle = function(opts) { b.require('./test/mocks/FakeStorage', { expose: './mocks/FakeStorage' }); + b.require('./test/mocks/FakeLocalStorage', { + expose: './mocks/FakeLocalStorage' + }); b.require('./js/models/core/Message', { expose: '../js/models/core/Message' }); From 4e07b8812daec356de51946477176b78f2aba928 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 10:45:52 -0400 Subject: [PATCH 04/10] fixing build.js one error at a time 2 --- util/build.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/util/build.js b/util/build.js index c2de4694d..60e6b81f3 100644 --- a/util/build.js +++ b/util/build.js @@ -93,9 +93,15 @@ var createBundle = function(opts) { b.require('./js/models/core/Passphrase', { expose: '../js/models/core/Passphrase' }); + b.require('./js/models/core/HDPath', { + expose: '../js/models/core/HDPath' + }); b.require('./config', { expose: '../config' }); + b.require('./copay', { + expose: '../copay' + }); if (opts.dontminify) { //include dev dependencies From c56bfc626346f01b319e79410a4c37d899eb8dcb Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 11:00:20 -0400 Subject: [PATCH 05/10] fixing build.js one error at a time 3 --- js/app.js | 2 +- util/build.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/js/app.js b/js/app.js index 058dfbba6..268649363 100644 --- a/js/app.js +++ b/js/app.js @@ -20,7 +20,7 @@ var log = function() { } // From the bundle -var copay = require('copay'); +var copay = require('../copay'); var copayApp = window.copayApp = angular.module('copayApp', [ 'ngRoute', diff --git a/util/build.js b/util/build.js index 60e6b81f3..01bb2ebd1 100644 --- a/util/build.js +++ b/util/build.js @@ -78,6 +78,9 @@ var createBundle = function(opts) { b.require('./test/mocks/FakePayProServer', { expose: '../../mocks/FakePayProServer' }); + b.require('./test/mocks/FakeBuilder', { + expose: './mocks/FakeBuilder' + }); b.require('./js/models/network/WebRTC', { expose: '../js/models/network/WebRTC' }); @@ -99,6 +102,10 @@ var createBundle = function(opts) { b.require('./config', { expose: '../config' }); + b.require('./copay'); + b.require('./copay', { + expose: 'copay' + }); b.require('./copay', { expose: '../copay' }); From a731ebd0138f26b70c1bee27af2ec90eb645f7ec Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 11:14:16 -0400 Subject: [PATCH 06/10] fixing build.js one error at a time 4 --- js/app.js | 2 +- util/build.js | 14 +++++--------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/js/app.js b/js/app.js index 268649363..058dfbba6 100644 --- a/js/app.js +++ b/js/app.js @@ -20,7 +20,7 @@ var log = function() { } // From the bundle -var copay = require('../copay'); +var copay = require('copay'); var copayApp = window.copayApp = angular.module('copayApp', [ 'ngRoute', diff --git a/util/build.js b/util/build.js index 01bb2ebd1..807ce9c92 100644 --- a/util/build.js +++ b/util/build.js @@ -55,10 +55,10 @@ var createBundle = function(opts) { }); b.require('./js/models/core/Wallet'); b.require('./js/models/core/Wallet', { - expose: '../js/models/core/Wallet' + expose: '../../js/models/core/Wallet' }); b.require('./js/models/core/Wallet', { - expose: '../../js/models/core/Wallet' + expose: '../js/models/core/Wallet' }); b.require('./test/mocks/FakeStorage', { expose: './mocks/FakeStorage' @@ -78,6 +78,9 @@ var createBundle = function(opts) { b.require('./test/mocks/FakePayProServer', { expose: '../../mocks/FakePayProServer' }); + b.require('./test/mocks/FakePayProServer', { + expose: './mocks/FakePayProServer' + }); b.require('./test/mocks/FakeBuilder', { expose: './mocks/FakeBuilder' }); @@ -102,13 +105,6 @@ var createBundle = function(opts) { b.require('./config', { expose: '../config' }); - b.require('./copay'); - b.require('./copay', { - expose: 'copay' - }); - b.require('./copay', { - expose: '../copay' - }); if (opts.dontminify) { //include dev dependencies From 2725b7f6e183c92271abf1588a4564f5d2acf1e3 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 11:19:50 -0400 Subject: [PATCH 07/10] fixing build.js one error at a time 5 --- test/test.storage.LocalEncrypted.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/test.storage.LocalEncrypted.js b/test/test.storage.LocalEncrypted.js index 8ad081f06..45aad70bd 100644 --- a/test/test.storage.LocalEncrypted.js +++ b/test/test.storage.LocalEncrypted.js @@ -19,7 +19,11 @@ CryptoJS.AES.decrypt = function(a) { 'use strict'; var chai = chai || require('chai'); var should = chai.should(); -var copay = copay || require('../copay'); +try { + var copay = require('copay'); //browser +} catch (e) { + var copay = require('../copay'); //node +} var LocalEncrypted = copay.StorageLocalEncrypted; var fakeWallet = 'fake-wallet-id'; From 7f07e7b8ac44d906a8ef83610332d45f82704a7b Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 11:25:15 -0400 Subject: [PATCH 08/10] fixing build.js one error at a time 6 --- test/test.TxProposals.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/test.TxProposals.js b/test/test.TxProposals.js index 94f51964a..a7a25e727 100644 --- a/test/test.TxProposals.js +++ b/test/test.TxProposals.js @@ -13,7 +13,11 @@ var TransactionBuilder = bitcore.TransactionBuilder; var util = bitcore.util; var networks = bitcore.networks; var sinon = require('sinon'); -var copay = require('../copay'); +try { + var copay = require('copay'); //browser +} catch (e) { + var copay = require('../copay'); //node +} var FakeBuilder = require('./mocks/FakeBuilder'); var TxProposal = copay.TxProposal; From 6c79d3575dadaaa19b32474bd23081b30b798998 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 11:32:47 -0400 Subject: [PATCH 09/10] fixing build.js one error at a time 7 --- util/build.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/build.js b/util/build.js index 807ce9c92..cf90b861e 100644 --- a/util/build.js +++ b/util/build.js @@ -55,10 +55,10 @@ var createBundle = function(opts) { }); b.require('./js/models/core/Wallet'); b.require('./js/models/core/Wallet', { - expose: '../../js/models/core/Wallet' + expose: '../js/models/core/Wallet' }); b.require('./js/models/core/Wallet', { - expose: '../js/models/core/Wallet' + expose: '../../js/models/core/Wallet' }); b.require('./test/mocks/FakeStorage', { expose: './mocks/FakeStorage' @@ -76,10 +76,10 @@ var createBundle = function(opts) { expose: './mocks/FakeNetwork' }); b.require('./test/mocks/FakePayProServer', { - expose: '../../mocks/FakePayProServer' + expose: './mocks/FakePayProServer' }); b.require('./test/mocks/FakePayProServer', { - expose: './mocks/FakePayProServer' + expose: '../../mocks/FakePayProServer' }); b.require('./test/mocks/FakeBuilder', { expose: './mocks/FakeBuilder' From e857e34b1d3b2771d9adbb95c84f6b494345d89b Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Thu, 14 Aug 2014 11:51:56 -0400 Subject: [PATCH 10/10] fixing index.html and karma tests --- copay.js | 5 +++++ test/mocks/FakePayProServer.js | 7 ++++++- test/mocks/FakeWallet.js | 8 +++++++- test/test.PayPro.js | 4 ++-- test/test.Wallet.js | 2 +- 5 files changed, 21 insertions(+), 5 deletions(-) diff --git a/copay.js b/copay.js index 5b2711dc9..e4cda4988 100644 --- a/copay.js +++ b/copay.js @@ -14,5 +14,10 @@ var Insight = module.exports.Insight = require('./js/models/blockchain/Insight') var StorageLocalEncrypted = module.exports.StorageLocalEncrypted = require('./js/models/storage/LocalEncrypted'); module.exports.WalletFactory = require('./js/models/core/WalletFactory'); +module.exports.Wallet = require('./js/models/core/Wallet'); module.exports.version = require('./version'); module.exports.API = require('./API'); + + +// test hack :s, will fix +module.exports.FakePayProServer = require('./test/mocks/FakePayProServer'); diff --git a/test/mocks/FakePayProServer.js b/test/mocks/FakePayProServer.js index e1e507201..3fbc05365 100644 --- a/test/mocks/FakePayProServer.js +++ b/test/mocks/FakePayProServer.js @@ -5,7 +5,12 @@ var is_browser = typeof process == 'undefined' var bitcore = bitcore || require('bitcore'); var Buffer = bitcore.Buffer; var PayPro = bitcore.PayPro; -var Wallet = require('../../js/models/core/Wallet'); +try { + var copay = require('copay'); //browser +} catch (e) { + var copay = require('../../copay'); //node +} +var Wallet = copay.Wallet; var x509 = { priv: '' diff --git a/test/mocks/FakeWallet.js b/test/mocks/FakeWallet.js index d5eceef10..d83829e5a 100644 --- a/test/mocks/FakeWallet.js +++ b/test/mocks/FakeWallet.js @@ -1,4 +1,10 @@ -var Wallet = require('../../js/models/core/Wallet'); + +try { + var copay = require('copay'); //browser +} catch (e) { + var copay = require('../copay'); //node +} +var Wallet = copay.Wallet; var FakeWallet = function() { diff --git a/test/test.PayPro.js b/test/test.PayPro.js index 9e50889a6..af6107e35 100644 --- a/test/test.PayPro.js +++ b/test/test.PayPro.js @@ -11,7 +11,7 @@ if (is_browser) { var copay = require('../copay'); //node } var copayConfig = require('../config'); -var Wallet = require('../js/models/core/Wallet'); +var Wallet = copay.Wallet; var PrivateKey = copay.PrivateKey; var Storage = require('./mocks/FakeStorage'); var Network = require('./mocks/FakeNetwork'); @@ -22,7 +22,7 @@ var Transaction = bitcore.Transaction; var Address = bitcore.Address; var PayPro = bitcore.PayPro; var bignum = bitcore.Bignum; -var startServer = require('./mocks/FakePayProServer'); +var startServer = copay.FakePayProServer; // TODO should be require('./mocks/FakePayProServer'); var server; diff --git a/test/test.Wallet.js b/test/test.Wallet.js index f39287428..75a2d9988 100644 --- a/test/test.Wallet.js +++ b/test/test.Wallet.js @@ -10,7 +10,7 @@ if (is_browser) { var copay = require('../copay'); //node } var copayConfig = require('../config'); -var Wallet = require('../js/models/core/Wallet'); +var Wallet = copay.Wallet; var PrivateKey = copay.PrivateKey; var Storage = require('./mocks/FakeStorage'); var Network = require('./mocks/FakeNetwork');