From 779db5a06c01fb4bfc6041f1de6c5a77317103b1 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Mon, 3 Aug 2015 20:39:09 -0300 Subject: [PATCH 1/8] Advanced send options --- public/views/preferences.html | 4 +++ public/views/walletHome.html | 27 ++++++++++++++++++ src/js/controllers/index.js | 9 ++++++ src/js/controllers/preferences.js | 16 +++++++++++ src/js/controllers/walletHome.js | 46 ++++++++++--------------------- src/js/services/feeService.js | 4 +-- 6 files changed, 73 insertions(+), 33 deletions(-) diff --git a/public/views/preferences.html b/public/views/preferences.html index c5f31797e..41dccf56c 100644 --- a/public/views/preferences.html +++ b/public/views/preferences.html @@ -84,6 +84,10 @@ {{index.feeOpts[index.currentFeeLevel]|translate}} +
  • + Spend Unconfirmed Transaction + +
  • Bitcore Wallet Service diff --git a/public/views/walletHome.html b/public/views/walletHome.html index 69df80a74..349bb8c93 100644 --- a/public/views/walletHome.html +++ b/public/views/walletHome.html @@ -418,6 +418,33 @@ +
    + + + Show Advanced options + Hide Advanced options + + + +
    +
    +

    Fee policy for this transaction

    +
      +
    • + {{index.feeOpts[fee.level]|translate}} + +
      • +
    +

    Spend unconfirmed transaction

    +
    + Use unconfirmed in this transaction + +
    +
    + +
    Cancel diff --git a/src/js/controllers/index.js b/src/js/controllers/index.js index 775acfcdc..15ce7f58b 100644 --- a/src/js/controllers/index.js +++ b/src/js/controllers/index.js @@ -279,6 +279,7 @@ angular.module('copayApp.controllers').controller('indexController', function($r $log.debug('Wallet Status:', walletStatus); self.setPendingTxps(walletStatus.pendingTxps); self.setFees(); + self.setSpendUnconfirmed(); // Status Shortcuts self.walletName = walletStatus.wallet.name; @@ -306,6 +307,10 @@ angular.module('copayApp.controllers').controller('indexController', function($r }); }; + self.setSpendUnconfirmed = function() { + self.spendUnconfirmed = configService.getSync().wallet.spendUnconfirmed; + }; + self.setCurrentFeeLevel = function(level) { self.currentFeeLevel = level || configService.getSync().wallet.settings.feeLevel || 'priority'; }; @@ -855,6 +860,10 @@ angular.module('copayApp.controllers').controller('indexController', function($r }); }); + $rootScope.$on('Local/SpendUnconfirmedUpdated', function(event) { + self.setSpendUnconfirmed(); + }); + $rootScope.$on('Local/FeeLevelUpdated', function(event, level) { self.setCurrentFeeLevel(level); }); diff --git a/src/js/controllers/preferences.js b/src/js/controllers/preferences.js index 742db5a84..c562785bb 100644 --- a/src/js/controllers/preferences.js +++ b/src/js/controllers/preferences.js @@ -9,10 +9,25 @@ angular.module('copayApp.controllers').controller('preferencesController', name: config.wallet.settings.alternativeName, isoCode: config.wallet.settings.alternativeIsoCode }; + $scope.spendUnconfirmed = config.wallet.spendUnconfirmed; var fc = profileService.focusedClient; if (fc) $scope.encrypt = fc.hasPrivKeyEncrypted(); + var unwatchSpendUnconfirmed = $scope.$watch('spendUnconfirmed', function(newVal, oldVal) { + if (newVal == oldVal) return; + var opts = { + wallet: { + spendUnconfirmed: newVal + } + }; + $rootScope.$emit('Local/SpendUnconfirmedUpdated'); + + configService.set(opts, function(err) { + if (err) $log.debug(err); + }); + }); + var unwatch = $scope.$watch('encrypt', function(val) { var fc = profileService.focusedClient; if (!fc) return; @@ -49,5 +64,6 @@ angular.module('copayApp.controllers').controller('preferencesController', $scope.$on('$destroy', function() { unwatch(); + unwatchSpendUnconfirmed(); }); }); diff --git a/src/js/controllers/walletHome.js b/src/js/controllers/walletHome.js index efa6e28f7..ec96ba394 100644 --- a/src/js/controllers/walletHome.js +++ b/src/js/controllers/walletHome.js @@ -5,6 +5,7 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi var self = this; $rootScope.hideMenuBar = false; $rootScope.wpInputFocused = false; + $scope.currentSpendUnconfirmed = configService.getSync().wallet.spendUnconfirmed; // INIT var config = configService.getSync().wallet.settings; @@ -538,6 +539,15 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi // Send + var unwatchSpendUnconfirmed = $scope.$watch('currentSpendUnconfirmed', function(newVal, oldVal) { + if (newVal == oldVal) return; + $scope.currentSpendUnconfirmed = newVal; + }); + + $scope.$on('$destroy', function() { + unwatchSpendUnconfirmed(); + }); + this.canShowAlternative = function() { return $scope.showAlternative; }; @@ -736,7 +746,7 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi address = form.address.$modelValue; amount = parseInt((form.amount.$modelValue * unitToSat).toFixed(0)); - feeService.getCurrentFeeValue(function(err, feePerKb) { + feeService.getCurrentFeeValue(self.currentSendFeeLevel, function(err, feePerKb) { if (err) $log.debug(err); fc.sendTxProposal({ toAddress: address, @@ -744,6 +754,7 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi message: comment, payProUrl: paypro ? paypro.url : null, feePerKb: feePerKb, + excludeUnconfirmedUtxos: $scope.currentSpendUnconfirmed ? false : true }, function(err, txp) { if (err) { self.setOngoingProcess(); @@ -848,6 +859,9 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi this.lockAddress = false; this.lockAmount = false; + this.currentSendFeeLevel = null; + this.hideAdvSend = true; + $scope.currentSpendUnconfirmed = configService.getSync().wallet.spendUnconfirmed; this._amount = this._address = null; @@ -985,36 +999,6 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi } }; - // Advanced SEND: set temporary fee policy for each transaction - this.openAdvancedSendModal = function(feeLevels, currentFeeLevel) { - var fc = profileService.focusedClient; - - var ModalInstanceCtrl = function($scope, $modalInstance) { - $scope.feeLevels = feeLevels; - $scope.currentFeeLevel = currentFeeLevel - $scope.network = fc.credentials.network; - $scope.color = fc.backgroundColor; - $scope.save = function(level) { - $scope.currentFeeLevel = level; - }; - - $scope.cancel = function() { - $modalInstance.dismiss('cancel'); - }; - }; - var modalInstance = $modal.open({ - templateUrl: 'views/modals/advancedSend.html', - windowClass: 'full animated slideInUp', - controller: ModalInstanceCtrl - }); - - modalInstance.result.finally(function() { - var m = angular.element(document.getElementsByClassName('reveal-modal')); - m.addClass('slideOutDown'); - }); - }; - - // History function strip(number) { diff --git a/src/js/services/feeService.js b/src/js/services/feeService.js index 99dde9bff..e77901bc4 100644 --- a/src/js/services/feeService.js +++ b/src/js/services/feeService.js @@ -10,10 +10,10 @@ angular.module('copayApp.services').factory('feeService', function($log, profile economy: gettextCatalog.getString('Economy') }; - root.getCurrentFeeValue = function(cb) { + root.getCurrentFeeValue = function(currentSendFeeLevel, cb) { var fc = profileService.focusedClient; var config = configService.getSync().wallet.settings; - var feeLevel = config.feeLevel || 'normal'; + var feeLevel = currentSendFeeLevel || config.feeLevel || 'normal'; // static fee var fee = 10000; fc.getFeeLevels(fc.credentials.network, function(err, levels) { From 12d132c37a873dc0dda045a4a116d9b4cb4b7b0d Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 5 Aug 2015 10:44:29 -0300 Subject: [PATCH 2/8] Updates angular-bwc and new error messages --- bower.json | 2 +- src/js/controllers/index.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/bower.json b/bower.json index 572438ec3..93266daf7 100644 --- a/bower.json +++ b/bower.json @@ -17,7 +17,7 @@ "ng-lodash": "~0.2.0", "angular-moment": "~0.10.1", "moment": "~2.10.3", - "angular-bitcore-wallet-client": "^0.0.28", + "angular-bitcore-wallet-client": "^0.1.1", "angular-ui-router": "~0.2.13", "qrcode-decoder-js": "*", "fastclick": "*", diff --git a/src/js/controllers/index.js b/src/js/controllers/index.js index 15ce7f58b..bb0a1b9ad 100644 --- a/src/js/controllers/index.js +++ b/src/js/controllers/index.js @@ -400,9 +400,9 @@ angular.module('copayApp.controllers').controller('indexController', function($r self.handleError = function(err) { $log.warn('Client ERROR:', err); - if (err.code === 'NOTAUTHORIZED') { + if (err.code === 'NOT_AUTHORIZED') { $scope.$emit('Local/NotAuthorized'); - } else if (err.code === 'NOTFOUND') { + } else if (err.code === 'NOT_FOUND') { $scope.$emit('Local/BWSNotFound'); } else { $scope.$emit('Local/ClientError', (err.error ? err.error : err)); @@ -960,12 +960,12 @@ angular.module('copayApp.controllers').controller('indexController', function($r }); $rootScope.$on('Local/ClientError', function(event, err) { - if (err.code && err.code === 'NOTAUTHORIZED') { + if (err.code && err.code === 'NOT_AUTHORIZED') { // Show not error, just redirect to home (where the recreate option is shown) go.walletHome(); } else if (err && err.cors == 'rejected') { $log.debug('CORS error:', err); - } else if (err.code === 'ETIMEDOUT' || err.code === 'CONNERROR') { + } else if (err.code === 'ETIMEDOUT' || err.code === 'CONNECTION_ERROR') { $log.debug('Time out:', err); } else { var msg = 'Error at Wallet Service: '; From 4a79dbd01f4c442aa10d9a75239b90e2b0238a62 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 5 Aug 2015 12:56:25 -0300 Subject: [PATCH 3/8] Fix layout. Adds spend unconfirmed to txp details --- public/views/includes/output.html | 2 +- public/views/modals/txp-details.html | 4 ++++ public/views/walletHome.html | 34 ++++++++++++++-------------- 3 files changed, 22 insertions(+), 18 deletions(-) diff --git a/public/views/includes/output.html b/public/views/includes/output.html index d217412b2..2fb157df1 100644 --- a/public/views/includes/output.html +++ b/public/views/includes/output.html @@ -1,4 +1,4 @@ -
    +
  • Recipients: {{output.recipientCount}} diff --git a/public/views/modals/txp-details.html b/public/views/modals/txp-details.html index 783668dae..c1abe1c16 100644 --- a/public/views/modals/txp-details.html +++ b/public/views/modals/txp-details.html @@ -30,6 +30,10 @@ Fee: {{feeStr}}
    • +
  • + Spend Unconfirmed Transactions: + {{(tx.excludeUnconfirmedUtxos ? 'No' : 'Yes')|translate}} +
  • Time: diff --git a/public/views/walletHome.html b/public/views/walletHome.html index 349bb8c93..986297b7d 100644 --- a/public/views/walletHome.html +++ b/public/views/walletHome.html @@ -418,29 +418,29 @@ -
    - +
    + Show Advanced options Hide Advanced options -
    -
    -

    Fee policy for this transaction

    -
      -
    • - {{index.feeOpts[fee.level]|translate}} - -
      • -
    -

    Spend unconfirmed transaction

    -
    - Use unconfirmed in this transaction - +
    +

    Fee policy for this transaction

    +
      +
    • + {{index.feeOpts[fee.level]|translate}} + +
      • +
    +

    Unconfirmed transactions for this transaction

    +
    + Spend Unconfirmed Transactions + +
    From a034c832beb4f0ef711ba34956b8c6ebd37608c4 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 5 Aug 2015 14:07:09 -0300 Subject: [PATCH 4/8] Fix typos. Updates with suggestions --- public/views/modals/txp-details.html | 2 +- public/views/preferences.html | 2 +- public/views/walletHome.html | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/public/views/modals/txp-details.html b/public/views/modals/txp-details.html index c1abe1c16..6460111a2 100644 --- a/public/views/modals/txp-details.html +++ b/public/views/modals/txp-details.html @@ -31,7 +31,7 @@ {{feeStr}}
  • - Spend Unconfirmed Transactions: + Uses unconfirmed funds: {{(tx.excludeUnconfirmedUtxos ? 'No' : 'Yes')|translate}}
  • diff --git a/public/views/preferences.html b/public/views/preferences.html index 41dccf56c..416dd9522 100644 --- a/public/views/preferences.html +++ b/public/views/preferences.html @@ -85,7 +85,7 @@
  • - Spend Unconfirmed Transaction + Use Unconfirmed Funds
  • diff --git a/public/views/walletHome.html b/public/views/walletHome.html index 986297b7d..951e56c88 100644 --- a/public/views/walletHome.html +++ b/public/views/walletHome.html @@ -436,9 +436,9 @@ ng-show="(home.currentSendFeeLevel || index.currentFeeLevel) == fee.level">
    • -

    Unconfirmed transactions for this transaction

    +

    Use unconfirmed funds for this transaction

    - Spend Unconfirmed Transactions + Use Unconfirmed Funds
    From d8a155a0e81c88881e8140b2fc5829eaa59bba45 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 5 Aug 2015 16:34:05 -0300 Subject: [PATCH 5/8] Hide options if it is the old bws --- public/views/preferences.html | 5 +++-- public/views/preferencesFee.html | 2 +- public/views/walletHome.html | 22 ++++++++++++---------- src/js/services/feeService.js | 8 ++------ 4 files changed, 18 insertions(+), 19 deletions(-) diff --git a/public/views/preferences.html b/public/views/preferences.html index 416dd9522..3f1e1d0cf 100644 --- a/public/views/preferences.html +++ b/public/views/preferences.html @@ -77,11 +77,12 @@ {{preferences.selectedAlternative.name}} -
  • +
  • Bitcoin Network Fee Policy - {{index.feeOpts[index.currentFeeLevel]|translate}} + {{index.feeOpts[index.currentFeeLevel]|translate}}
  • diff --git a/public/views/preferencesFee.html b/public/views/preferencesFee.html index 425164145..7eb64566d 100644 --- a/public/views/preferencesFee.html +++ b/public/views/preferencesFee.html @@ -7,7 +7,7 @@
    • - {{index.feeOpts[fee.level]|translate}} + {{index.feeOpts[fee.level]|translate}}
    diff --git a/public/views/walletHome.html b/public/views/walletHome.html index 951e56c88..02ecebe38 100644 --- a/public/views/walletHome.html +++ b/public/views/walletHome.html @@ -427,16 +427,18 @@
    -

    Fee policy for this transaction

    -
      -
    • - {{index.feeOpts[fee.level]|translate}} - -
      • -
    -

    Use unconfirmed funds for this transaction

    +
    +

    Fee policy for this transaction

    +
      +
    • + {{index.feeOpts[fee.level]|translate}} + +
      • +
    +
    +

     

    Use Unconfirmed Funds diff --git a/src/js/services/feeService.js b/src/js/services/feeService.js index e77901bc4..3b7f810ce 100644 --- a/src/js/services/feeService.js +++ b/src/js/services/feeService.js @@ -1,6 +1,6 @@ 'use strict'; -angular.module('copayApp.services').factory('feeService', function($log, profileService, configService, gettextCatalog) { +angular.module('copayApp.services').factory('feeService', function($log, profileService, configService, gettextCatalog, lodash) { var root = {}; // Constant fee options to translate @@ -21,11 +21,7 @@ angular.module('copayApp.services').factory('feeService', function($log, profile return cb({message: 'Could not get dynamic fee. Using static 10000sat'}, fee); } else { - for (var i = 0; i < 3; i++) { - if (levels[i].level == feeLevel) { - fee = levels[i].feePerKB; - } - } + fee = lodash.find(levels, { level: feeLevel }).feePerKB; $log.debug('Dynamic fee for ' + feeLevel + ': ' + fee); return cb(null, fee); } From 45c32371d671b7bd725a1976fd535315e960956f Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 5 Aug 2015 16:44:58 -0300 Subject: [PATCH 6/8] Fixes some capitalized words --- public/views/backup.html | 4 ++-- public/views/create.html | 4 ++-- public/views/join.html | 4 ++-- public/views/walletHome.html | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/public/views/backup.html b/public/views/backup.html index d3cb3387b..f0f0d7a22 100644 --- a/public/views/backup.html +++ b/public/views/backup.html @@ -38,8 +38,8 @@
    - Show Advanced options - Hide Advanced options + Show advanced options + Hide advanced options diff --git a/public/views/create.html b/public/views/create.html index d721f7b13..83f02975d 100644 --- a/public/views/create.html +++ b/public/views/create.html @@ -81,8 +81,8 @@
    - Show Advanced options - Hide Advanced options + Show advanced options + Hide advanced options diff --git a/public/views/join.html b/public/views/join.html index c18aed109..7c4a19f8a 100644 --- a/public/views/join.html +++ b/public/views/join.html @@ -66,8 +66,8 @@ - Show Advanced options - Hide Advanced options + Show advanced options + Hide advanced options diff --git a/public/views/walletHome.html b/public/views/walletHome.html index 02ecebe38..a9353d02c 100644 --- a/public/views/walletHome.html +++ b/public/views/walletHome.html @@ -421,8 +421,8 @@
    - Show Advanced options - Hide Advanced options + Show advanced options + Hide advanced options From 3e87998981b8dc8d5e51b8228f97fa907340d370 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Mon, 10 Aug 2015 11:31:23 -0300 Subject: [PATCH 7/8] Updates template.pot --- i18n/po/template.pot | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/i18n/po/template.pot b/i18n/po/template.pot index 7c4e1ecaa..9b384c51c 100644 --- a/i18n/po/template.pot +++ b/i18n/po/template.pot @@ -468,6 +468,10 @@ msgstr "" msgid "Fee Policy" msgstr "" +#: public/views/walletHome.html +msgid "Fee policy for this transaction" +msgstr "" + #. Get information of payment if using Payment Protocol #: src/js/controllers/walletHome.js msgid "Fetching Payment Information" @@ -524,7 +528,8 @@ msgstr "" #: public/views/backup.html #: public/views/create.html #: public/views/join.html -msgid "Hide Advanced options" +#: public/views/walletHome.html +msgid "Hide advanced options" msgstr "" #: src/js/controllers/index.js @@ -689,6 +694,7 @@ msgstr "" #: public/views/walletHome.html #: public/views/includes/output.html +#: public/views/modals/tx-details.html msgid "Note" msgstr "" @@ -1012,7 +1018,8 @@ msgstr "" #: public/views/backup.html #: public/views/create.html #: public/views/join.html -msgid "Show Advanced options" +#: public/views/walletHome.html +msgid "Show advanced options" msgstr "" #: src/js/controllers/walletHome.js @@ -1148,6 +1155,15 @@ msgstr "" msgid "Updating Wallet..." msgstr "" +#: public/views/preferences.html +#: public/views/walletHome.html +msgid "Use Unconfirmed Funds" +msgstr "" + +#: public/views/modals/txp-details.html +msgid "Uses unconfirmed funds" +msgstr "" + #: public/views/preferencesAbout.html msgid "Version" msgstr "" From 1613062f48baa7f162edc2a542109edb2f0904f2 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Tue, 11 Aug 2015 01:21:50 -0300 Subject: [PATCH 8/8] Disables alert() function for chromeapp --- src/js/controllers/index.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/js/controllers/index.js b/src/js/controllers/index.js index bb0a1b9ad..e8a820836 100644 --- a/src/js/controllers/index.js +++ b/src/js/controllers/index.js @@ -1,6 +1,6 @@ 'use strict'; -angular.module('copayApp.controllers').controller('indexController', function($rootScope, $scope, $log, $filter, $timeout, lodash, go, profileService, configService, isCordova, rateService, storageService, addressService, gettextCatalog, gettext, amMoment, nodeWebkit, addonManager, feeService) { +angular.module('copayApp.controllers').controller('indexController', function($rootScope, $scope, $log, $filter, $timeout, lodash, go, profileService, configService, isCordova, rateService, storageService, addressService, gettextCatalog, gettext, amMoment, nodeWebkit, addonManager, feeService, isChromeApp) { var self = this; self.isCordova = isCordova; self.onGoingProcess = {}; @@ -752,7 +752,9 @@ angular.module('copayApp.controllers').controller('indexController', function($r 'Wallet Server Error', ['OK'] ); } else { - alert(err); + if (!isChromeApp) { + alert(err); + } } }; @@ -764,7 +766,9 @@ angular.module('copayApp.controllers').controller('indexController', function($r 'Device Error', ['OK'] ); } else { - alert(err); + if (!isChromeApp) { + alert(err); + } } };