anders/Wallet
1
0
Fork 0
Code Issues Projects Releases Packages Wiki Activity

More tests on TxProposal

Browse source
This commit is contained in:
Matias Pando 2015-02-04 17:43:16 -03:00
commit a530c27b2e
2 changed files with 29 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
js/models/TxProposal.js
View file

@ -154,12 +154,6 @@ TxProposal.prototype._check = function() {
};
TxProposal.prototype.trimForStorage = function() {
// TODO (remove builder / builderObj. utxos, etc)
//
return this;
};
TxProposal.prototype.addMerchantData = function(merchantData) {
preconditions.checkArgument(merchantData.pr);
preconditions.checkArgument(merchantData.request_url);

29
test/TxProposal.js
View file

@ -431,6 +431,17 @@ describe('TxProposal', function() {
it('OK', function() {
dummyProposal({})._check();
});
it('FAIL Invalid tx proposal', function() {
var txp = dummyProposal();
var old = txp.builder.signhash;
txp.builder.signhash = 'ppp';
(function() {
txp._check();
}).should.throw('Invalid tx proposal');
txp.builder.signhash = old;
});
it('FAIL ins', function() {
(function() {
dummyProposal({
@ -438,6 +449,24 @@ describe('TxProposal', function() {
})._check();
}).should.throw('no ins');
});
it('FAIL txp too big ', function() {
var txp = dummyProposal();
var old_builder = txp.builder.build;
var tx = {
getSize: function() {
return 90000;
}
};
txp.builder.build = sinon.stub().returns(tx);;
(function() {
txp._check();
}).should.throw('BIG: Invalid TX proposal. Too big');
txp.builder.build = old_builder;
});
it('FAIL signhash SINGLE', function() {
var txp = dummyProposal({
hashtype: Transaction.SIGHASH_SINGLE