From b011df787c75b648a0b56ade98e268b9f523fe76 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javier=20Donad=C3=ADo?= <tanojaja@gmail.com>
Date: Wed, 13 Apr 2016 14:05:36 -0300
Subject: [PATCH] replace send all to send max (#4010)

* fix prevent submit

* replace send all to send max

* fix params and errors

* add warnings in case to exclude utxos

* remove unnecessaries parameters and variables

* verify exclude utxos before checking amount

* bump bwc dependency to v2.2.1

* fix message text
---
 public/views/walletHome.html     |  6 +--
 src/js/controllers/walletHome.js | 83 +++++++++++++++++++++++---------
 2 files changed, 62 insertions(+), 27 deletions(-)

diff --git a/public/views/walletHome.html b/public/views/walletHome.html
index 7781e6865..4b030b926 100644
--- a/public/views/walletHome.html
+++ b/public/views/walletHome.html
@@ -390,11 +390,11 @@
           <available-balance></available-balance>
           <span
             ng-show="home.lockedCurrentFeePerKb || home.blockUx || home.lockAmount"
-            class="text-gray" translate>Send All</span>
+            class="text-gray" translate>Send Max</span>
           <a
             ng-show="index.availableBalanceSat > 0 && !home.lockedCurrentFeePerKb && !home.blockUx && !home.lockAmount"
-            ng-click="home.sendAll(index.totalBytesToSendMax, index.availableBalanceSat)"
-             translate> Send All
+            ng-click="home.sendMax(index.availableBalanceSat)"
+             translate>Send Max
           </a>
           <div ng-show="!home.paymentExpired && home._paypro">
             <span translate>Payment expires</span>
diff --git a/src/js/controllers/walletHome.js b/src/js/controllers/walletHome.js
index 4ec000ee4..e9daf60fa 100644
--- a/src/js/controllers/walletHome.js
+++ b/src/js/controllers/walletHome.js
@@ -1243,44 +1243,79 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi
     return actions.hasOwnProperty('create');
   };
 
-  this._doSendAll = function(amount) {
+  this._doSendMax = function(amount) {
     this.setForm(null, amount, null);
   };
 
-  this.sendAll = function(totalBytesToSendMax, availableBalanceSat) {
+  this.sendMax = function(availableBalanceSat) {
+    if (availableBalanceSat == 0) {
+      this.error = gettext("Cannot create transaction. Insufficient funds");
+      return;
+    }
+
     var self = this;
-    var availableMaxBalance;
-    var feeToSendMaxStr;
+    var fc = profileService.focusedClient;
     this.error = null;
     this.setOngoingProcess(gettextCatalog.getString('Calculating fee'));
 
     feeService.getCurrentFeeValue(function(err, feePerKb) {
-      self.setOngoingProcess();
-      if (err || lodash.isNull(feePerKb)) {
+      if (err || !lodash.isNumber(feePerKb)) {
+        self.setOngoingProcess();
         self.error = gettext('Could not get fee value');
         return;
       }
 
-      var feeToSendMaxSat = parseInt(((totalBytesToSendMax * feePerKb) / 1000.).toFixed(0));
-      if (availableBalanceSat > feeToSendMaxSat) {
-        self.lockedCurrentFeePerKb = feePerKb;
-        availableMaxBalance = strip((availableBalanceSat - feeToSendMaxSat) * self.satToUnit);
-        feeToSendMaxStr = profileService.formatAmount(feeToSendMaxSat) + ' ' + self.unitName;
-      } else {
-        self.error = gettext('Not enought funds for fee');
-        return;
-      }
+      var opts = {};
+      opts.feePerKb = feePerKb;
+      opts.returnInputs = true;
+      var config = configService.getSync();
+      opts.excludeUnconfirmedUtxos = !config.wallet.spendUnconfirmed;
+      self.setOngoingProcess(gettextCatalog.getString('Retrieving inputs information'));
 
-      var msg = gettextCatalog.getString("{{fee}} will be deducted for bitcoin networking fees", {
-        fee: feeToSendMaxStr
-      });
+      fc.getSendMaxInfo(opts, function(err, resp) {
+        self.setOngoingProcess();
+        if (err) {
+          self.error = err;
+          $scope.$apply();
+          return;
+        }
 
-      $scope.$apply();
-      confirmDialog.show(msg, function(confirmed) {
-        if (confirmed) {
-          self._doSendAll(availableMaxBalance);
-        } else {
-          self.resetForm();
+        if (resp.amount == 0) {
+          self.error = gettext("Not enought funds for fee");
+          $scope.$apply();
+          return;
+        }
+
+        var msg = gettextCatalog.getString("{{fee}} will be deducted for bitcoin networking fees", {
+          fee: profileService.formatAmount(resp.fee) + ' ' + self.unitName
+        });
+
+        var warningMsg = verifyExcludedUtxos();
+
+        if (!lodash.isEmpty(warningMsg))
+          msg += '. \n' + warningMsg;
+
+        confirmDialog.show(msg, function(confirmed) {
+          if (confirmed) {
+            self._doSendMax(resp.amount * self.satToUnit);
+          } else {
+            self.resetForm();
+          }
+        });
+
+        function verifyExcludedUtxos() {
+          var warningMsg = [];
+          if (resp.utxosBelowFee > 0) {
+            warningMsg.push(gettextCatalog.getString("Note: a total of {{amountBelowFeeStr}} were excluded. These funds come from UTXOs smaller than the network fee provided.", {
+              amountBelowFeeStr: profileService.formatAmount(resp.amountBelowFee) + ' ' + self.unitName
+            }));
+          }
+          if (resp.utxosAboveMaxSize > 0) {
+            warningMsg.push(gettextCatalog.getString("Note: a total of {{amountAboveMaxSizeStr}} were excluded. The maximum size allowed for a transaction was exceeded", {
+              amountAboveMaxSizeStr: profileService.formatAmount(resp.amountAboveMaxSize) + ' ' + self.unitName
+            }));
+          }
+          return warningMsg.join('\n');
         }
       });
     });