From 2d3da332c4bf45e9b00013d2a23eba48c3e3e7f0 Mon Sep 17 00:00:00 2001 From: Matias Alejo Garcia Date: Tue, 7 Feb 2017 16:13:28 -0500 Subject: [PATCH 1/3] fix storage pull --- src/js/services/storageService.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/js/services/storageService.js b/src/js/services/storageService.js index 5f78725a3..8b3b2618d 100644 --- a/src/js/services/storageService.js +++ b/src/js/services/storageService.js @@ -414,9 +414,9 @@ angular.module('copayApp.services') // } root.removeBitpayDebitCard = function(network, cardEid, cb) { - root.getBitpayAccounts(network, function(err, allAccounts){ + root.getBitpayAccounts(network, function(err, allAccounts) { - lodash.each(allAccounts, function(account){ + lodash.each(allAccounts, function(account) { account.cards = lodash.reject(account.cards, { 'eid': cardEid }); @@ -450,7 +450,10 @@ angular.module('copayApp.services') var allAccounts = {}; try { allAccounts = JSON.parse(allAccountsStr); - } catch (e) {}; + } catch (e) { + $log.error('Bad storage value for bitpayAccount-v2' + allAccountsStr) + return cb(null, {}); + }; var anyMigration; @@ -474,10 +477,10 @@ angular.module('copayApp.services') }); if (anyMigration) { - storage.set('bitpayAccounts-v2-' + network, allAccounts, function(){ + storage.set('bitpayAccounts-v2-' + network, allAccounts, function() { return cb(err, allAccounts); }); - } else + } else return cb(err, allAccounts); }); From 05f10e1135dde597a1504f8d0424950949bc7225 Mon Sep 17 00:00:00 2001 From: Matias Alejo Garcia Date: Tue, 7 Feb 2017 16:16:21 -0500 Subject: [PATCH 2/3] fix storage --- src/js/services/storageService.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/js/services/storageService.js b/src/js/services/storageService.js index 8b3b2618d..668e8c66a 100644 --- a/src/js/services/storageService.js +++ b/src/js/services/storageService.js @@ -447,6 +447,9 @@ angular.module('copayApp.services') storage.get('bitpayAccounts-v2-' + network, function(err, allAccountsStr) { if (err) return cb(err); + if (!allAccountsStr) + return cb(null, {}); + var allAccounts = {}; try { allAccounts = JSON.parse(allAccountsStr); From 6f0ec48af7222f7a40159843b38089ded49cd727 Mon Sep 17 00:00:00 2001 From: Matias Alejo Garcia Date: Tue, 7 Feb 2017 16:19:20 -0500 Subject: [PATCH 3/3] v1.3.6 --- app-template/bitpay/appConfig.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app-template/bitpay/appConfig.json b/app-template/bitpay/appConfig.json index 2bdcef286..1c9decb34 100644 --- a/app-template/bitpay/appConfig.json +++ b/app-template/bitpay/appConfig.json @@ -21,8 +21,8 @@ "windowsAppId": "2d1002d7-ee34-4f60-bd29-0c871ba0c195", "pushSenderId": "1036948132229", "description": "Secure Bitcoin Wallet", - "version": "1.3.5", - "androidVersion": "135000", + "version": "1.3.6", + "androidVersion": "136000", "_extraCSS": null, "_enabledExtensions": { "coinbase": true,