diff --git a/public/views/modals/txp-details.html b/public/views/modals/txp-details.html index 4f9ad9c68..2b24ff00d 100644 --- a/public/views/modals/txp-details.html +++ b/public/views/modals/txp-details.html @@ -132,12 +132,12 @@ -
-
- * Only payment proposals created by yourself with no peer actions can be removed +
+
+ * A payment proposal can be deleted if 1) you are the creator, and no other copayer has signed, or 2) 24 hours have passed since the proposal was created.
diff --git a/src/js/controllers/index.js b/src/js/controllers/index.js index 183767817..e18c17d5a 100644 --- a/src/js/controllers/index.js +++ b/src/js/controllers/index.js @@ -365,9 +365,8 @@ angular.module('copayApp.controllers').controller('indexController', function($r tx.statusForUs = 'pending'; } - if (tx.creatorId == self.copayerId && tx.actions.length == 1) { - tx.couldRemove = true; - }; + if (!tx.deleteLockTime) + tx.canBeRemoved = true; if (tx.creatorId != self.copayerId) { self.pendingTxProposalsCountForUs = self.pendingTxProposalsCountForUs + 1; diff --git a/src/js/controllers/walletHome.js b/src/js/controllers/walletHome.js index 1454bf3ad..fb7ea0ba6 100644 --- a/src/js/controllers/walletHome.js +++ b/src/js/controllers/walletHome.js @@ -150,7 +150,7 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi if (err.code && err.code == 'BADREQUEST' && (eventName == 'transactionProposalRemoved' || eventName == 'TxProposalRemoved')) { $scope.tx.removed = true; - $scope.tx.couldRemove = false; + $scope.tx.canBeRemoved = false; $scope.tx.pendingForUs = false; $scope.$apply(); return; @@ -545,6 +545,8 @@ angular.module('copayApp.controllers').controller('walletHomeController', functi var errMessage = fc.credentials.m > 1 ? gettext('Could not create payment proposal') : gettext('Could not send payment'); + //This are abnormal situations, but still err message will not be translated + //(the should) we should switch using err.code and use proper gettext messages errMessage = errMessage + '. ' + (err.message ? err.message : gettext('Check you connection and try again')); this.error = errMessage;