From dcbdb31ab37b6522dde6968753c8a70dc17be899 Mon Sep 17 00:00:00 2001 From: Jason Dreyzehner Date: Tue, 15 Nov 2016 17:38:40 -0500 Subject: [PATCH] fix(feedback): more visual and design improvements on mobile --- src/js/controllers/feedback/complete.js | 4 +++- src/js/controllers/feedback/rateApp.js | 14 ++++++++++++++ src/sass/views/feedback/rateApp.scss | 10 +++++----- www/views/feedback/rateApp.html | 4 ++-- www/views/feedback/send.html | 2 +- 5 files changed, 25 insertions(+), 9 deletions(-) diff --git a/src/js/controllers/feedback/complete.js b/src/js/controllers/feedback/complete.js index 3f5a4e621..9f3e29077 100644 --- a/src/js/controllers/feedback/complete.js +++ b/src/js/controllers/feedback/complete.js @@ -32,6 +32,7 @@ angular.module('copayApp.controllers').controller('completeController', function $scope.$on("$ionicView.beforeEnter", function(event, data) { if(window.StatusBar){ + $log.debug('Hiding status bar...'); StatusBar.hide(); } @@ -83,8 +84,9 @@ angular.module('copayApp.controllers').controller('completeController', function }, 100); }); - $scope.$on("$ionicView.afterLeave", function(event, data) { + $scope.$on("$ionicView.afterLeave", function() { if(window.StatusBar){ + $log.debug('Showing status bar...'); StatusBar.show(); } }); diff --git a/src/js/controllers/feedback/rateApp.js b/src/js/controllers/feedback/rateApp.js index 3f472cf90..a7f8c6d49 100644 --- a/src/js/controllers/feedback/rateApp.js +++ b/src/js/controllers/feedback/rateApp.js @@ -29,6 +29,20 @@ angular.module('copayApp.controllers').controller('rateAppController', function( }); }; + $scope.$on("$ionicView.beforeEnter", function() { + if(window.StatusBar){ + $log.debug('Hiding status bar...'); + StatusBar.hide(); + } + }); + + $scope.$on("$ionicView.afterLeave", function() { + if(window.StatusBar){ + $log.debug('Showing status bar...'); + StatusBar.show(); + } + }); + $scope.sendFeedback = function() { $state.go('feedback.send', { score: $scope.score diff --git a/src/sass/views/feedback/rateApp.scss b/src/sass/views/feedback/rateApp.scss index 7b4e399ee..26b8841be 100644 --- a/src/sass/views/feedback/rateApp.scss +++ b/src/sass/views/feedback/rateApp.scss @@ -4,6 +4,9 @@ margin-top: 15px; color: #667; } + .skip-rating { + margin-right: 15px; + } .icon-svg > img { width: 80px; height: 80px; @@ -13,7 +16,7 @@ font-size: 20px; font-weight: bold; color: $dark-gray; - margin: 40px 50px 10px; + margin: 80px 50px 10px; text-align: center; } .subtitle { @@ -25,9 +28,6 @@ width: 100%; position: absolute; background-color: $subtle-gray; - .button { - margin-top: 40px; - margin-bottom: 30px; - } + padding: 50px 0; } } diff --git a/www/views/feedback/rateApp.html b/www/views/feedback/rateApp.html index 2d289c19a..e22ab866d 100644 --- a/www/views/feedback/rateApp.html +++ b/www/views/feedback/rateApp.html @@ -1,6 +1,6 @@ - +
Thank you!
@@ -10,7 +10,7 @@
- 5-star ratings help us get BitPay into more hands, and more users means more resoucers can be committed to the app! + 5-star ratings help us get BitPay into more hands, and more users means more resources can be committed to the app!
Would you be willing to rate BitPay in the app store? diff --git a/www/views/feedback/send.html b/www/views/feedback/send.html index 5cc519e73..1143dc33b 100644 --- a/www/views/feedback/send.html +++ b/www/views/feedback/send.html @@ -31,7 +31,7 @@
{{comment}}
- +