From 7643ea02cbfe5724b97a45c848b06ec882934168 Mon Sep 17 00:00:00 2001 From: Sebastiaan Pasma Date: Wed, 23 May 2018 11:35:19 +0200 Subject: [PATCH] Use External Link Service --- src/js/controllers/communityController.js | 8 ++------ src/js/controllers/nextStepsController.js | 8 ++------ src/js/controllers/tx-details.js | 2 +- 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/src/js/controllers/communityController.js b/src/js/controllers/communityController.js index d9f952666..b39d233ba 100644 --- a/src/js/controllers/communityController.js +++ b/src/js/controllers/communityController.js @@ -1,6 +1,6 @@ 'use strict'; -angular.module('copayApp.controllers').controller('communityController', function($scope, communityService, $ionicScrollDelegate, $timeout, platformInfo, configService) { +angular.module('copayApp.controllers').controller('communityController', function($scope, communityService, $ionicScrollDelegate, $timeout, platformInfo, configService, externalLinkService) { $scope.hide = false; @@ -29,11 +29,7 @@ angular.module('copayApp.controllers').controller('communityController', functio } $scope.open = function(url) { - if (platformInfo.isNW) { - require('nw.gui').Shell.openExternal( url ); - } else { - window.open(url, '_system'); - } + externalLinkService.open(url, false); } }); diff --git a/src/js/controllers/nextStepsController.js b/src/js/controllers/nextStepsController.js index ad2cbaf20..6d8021f08 100644 --- a/src/js/controllers/nextStepsController.js +++ b/src/js/controllers/nextStepsController.js @@ -1,6 +1,6 @@ 'use strict'; -angular.module('copayApp.controllers').controller('nextStepsController', function($scope, nextStepsService, $ionicScrollDelegate, $timeout, platformInfo, configService) { +angular.module('copayApp.controllers').controller('nextStepsController', function($scope, nextStepsService, $ionicScrollDelegate, $timeout, platformInfo, configService, externalLinkService) { $scope.hide = false; @@ -22,10 +22,6 @@ angular.module('copayApp.controllers').controller('nextStepsController', functio }; $scope.open = function(url) { - if (platformInfo.isNW) { - require('nw.gui').Shell.openExternal( url ); - } else { - window.open(url, '_system'); - } + externalLinkService.open(url, false) } }); diff --git a/src/js/controllers/tx-details.js b/src/js/controllers/tx-details.js index aec79a99e..7cac598cd 100644 --- a/src/js/controllers/tx-details.js +++ b/src/js/controllers/tx-details.js @@ -201,7 +201,7 @@ angular.module('copayApp.controllers').controller('txDetailsController', functio $scope.viewOnBlockchain = function() { var btx = $scope.btx; var url = 'https://' + ($scope.getShortNetworkName() == 'test' ? 'test-' : '') + blockexplorerUrl + '/tx/' + btx.txid; - window.open(url, '_system'); + externalLinkService.open(url, false); }; $scope.getShortNetworkName = function() {